RFR: 8228369: Shenandoah: Refactor LRB C1 stubs

Aleksey Shipilev shade at redhat.com
Mon Aug 12 13:13:17 UTC 2019


On 8/9/19 2:40 PM, Roman Kennke wrote:
> Incremental:
> http://cr.openjdk.java.net/~rkennke/JDK-8228369/webrev.02.diff/
> Full:
> http://cr.openjdk.java.net/~rkennke/JDK-8228369/webrev.02/

*) Note stuff like:
  623   __ blrt(lr, 1, 0, MacroAssembler::ret_type_integral);

...would not compile after AArch64 simulator removal (JDK-8228400). The equivalent is:
  __ blr(lr);

*) In src/hotspot/share/gc/shenandoah/c1/shenandoahBarrierSetC1.cpp,
_load_reference_barrier_rt_code_blob would be left uninitialized with -ShenandoahLoadRefBarrier?

  if (ShenandoahLoadRefBarrier) {
    C1ShenandoahLoadReferenceBarrierCodeGenClosure lrb_code_gen_cl;
    _load_reference_barrier_rt_code_blob = ...
  }

Otherwise looks good.

-- 
Thanks,
-Aleksey




More information about the hotspot-gc-dev mailing list