RFR (S): 8235346: [Redo] 8235247: WorkerDataArray leaks C heap memory for associated work items

Stefan Johansson stefan.johansson at oracle.com
Thu Dec 5 09:41:25 UTC 2019


Looks good, 
StefanJ

> 5 dec. 2019 kl. 10:20 skrev Thomas Schatzl <thomas.schatzl at oracle.com>:
> 
> Hi all,
> 
>  can I have reviews for this redo for 8235247: WorkerDataArray leaks C heap memory for associated work items; while the original change in the GC code has been correct, the associated gtest did double-frees, causing errors.
> 
> The test assumed that ownership of the sub-WorkerDataArray did not transfer, and it is responsible for freeing it.
> 
> This issue has not been caught in the original change because I only did local jtreg testing (which does not include jtreg) for this change separately. CI testing has only been done for this with the follow-up JDK-8235341 included which passed.
> 
> Sorry for this.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8235346
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8235346/webrev/
> Testing:
> hs-tier1-3
> 
> Thanks,
>  Thomas




More information about the hotspot-gc-dev mailing list