RFR(XS) 8224247: AllocateOldGenAt fires assertion failure

Kharbas, Kishor kishor.kharbas at intel.com
Mon Jun 3 18:27:49 UTC 2019


Thanks Thomas and Sangheon for the review. Tier1 tests also pass at my end.
@Sangheon, can you sponsor the patch?
I have the changeset at http://cr.openjdk.java.net/~kkharbas/8224247/8224247.patch.

Thanks,
Kishor

> -----Original Message-----
> From: Thomas Schatzl [mailto:thomas.schatzl at oracle.com]
> Sent: Wednesday, May 29, 2019 12:11 PM
> To: Kharbas, Kishor <kishor.kharbas at intel.com>; hotspot-gc-
> dev at openjdk.java.net
> Subject: Re: RFR(XS) 8224247: AllocateOldGenAt fires assertion failure
> 
> Hi,
> 
> On Tue, 2019-05-28 at 15:40 +0000, Kharbas, Kishor wrote:
> > Hi,
> >
> > Requesting review for,
> > CR : https://bugs.openjdk.java.net/browse/JDK-8224247
> > Webrev : http://cr.openjdk.java.net/~kkharbas/8224247/webrev.00
> >
> > [...]
> > The fix is just adding a new method and using it during initialization
> > of G1 and PS heap, but the existing method's name is more appropriate
> > for the new method. So I renamed existing method.
> > This would also avoid confusion about these methods down the line.
> >
> > Please suggest alternated approach if you see one.
> >
> 
>   looks good.
> 
> Thomas



More information about the hotspot-gc-dev mailing list