RFR 8225341: Shenandoah: CM::update_thread_roots() needs to handle derived pointers

Zhengyu Gu zgu at redhat.com
Wed Jun 5 13:16:53 UTC 2019



On 6/5/19 8:42 AM, Aleksey Shipilev wrote:
> On 6/5/19 2:38 PM, Zhengyu Gu wrote:
>> Update_thread_roots() may alter stack frames.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8225341
>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225341/webrev.00/
> 
> I think we should strive to use COMPILER2_OR_JVMCI macro, see
> ShenandoahMarkCompact::phase3_update_references. The remaining uses of older define should be
> cleaned up some time later.
Updated, retested and pushed.

Thanks,

-Zhengyu


> 
> Otherwise looks good.
> 
> -Aleksey
> 
> 



More information about the hotspot-gc-dev mailing list