RFR (S): 8225418: G1: region attribute remembered set state disagrees with actual remembered set state

[Doerr, Martin]

Hi Thomas,

looks good to me. Thanks for finding and fixing the issue.
Seems like the bug was introduced by JDK-8218668 which introduced abandon_optional_collection_set.
So only jdk13 should be affected. Right?

Best regards,
Martin


> -----Original Message-----
> From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> On
> Behalf Of Thomas Schatzl
> Sent: Samstag, 8. Juni 2019 12:46
> To: Kim Barrett <kim.barrett at oracle.com>
> Cc: hotspot-gc-dev <hotspot-gc-dev at openjdk.java.net>
> Subject: Re: RFR (S): 8225418: G1: region attribute remembered set state
> disagrees with actual remembered set state
> 
> Hi Kim,
> 
> On Fri, 2019-06-07 at 20:04 -0400, Kim Barrett wrote:
> > > On Jun 7, 2019, at 6:51 AM, Thomas Schatzl <
> > > thomas.schatzl at oracle.com> wrote:
> > >
> > > […]
> > > CR:
> > > https://bugs.openjdk.java.net/browse/JDK-8225418
> > > Webrev:
> > > http://cr.openjdk.java.net/~tschatzl/8225418/webrev/
> > > Testing:
> > > local jtreg passed with the change, failing without (with the
> > > verification only), hs-tier1-5 60% through
> 
> That test run passed without issues in the meantime.
> 
> > >
> > > Thanks,
> > >  Thomas
> > >
> > > [0]
> > >
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2019-
> May/025937.html
> >
> > Looks good.
> >
> 
>   thanks for your review.
> 
> Thomas