RFR (xs): 8221509: Refactor assert( G1CollectedHeap::used() == recalculate_used() ) with better message

Man Cao manc at google.com
Fri May 3 20:18:56 UTC 2019


Hi Sangheon,

The change looks good to me. I'm not an official "Reviewer" though.

-Man


*From: *<sangheon.kim at oracle.com>
*Date: *Tue, Apr 30, 2019 at 1:54 PM
*To: *hotspot-gc-dev

Hi all,
>
> Can I have some reviews that replace assert(used() ==
> recalculated_used()) with better message?
> Those assert messages are not much helpful as it doesn't include any
> actual values on it so I'm suggesting to include actual values of each
> and then replace as a macro.
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8221509
> webrev: http://cr.openjdk.java.net/~sangheki/8221509/webrev.0/
> testing: local build
>
> Thanks,
> Sangheon
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190503/625b9165/attachment.htm>


More information about the hotspot-gc-dev mailing list