RFR(XXS) 8224525: Shenandoah: Eliminate shenandoah verifier's side-effects

[Aleksey Shipilev]

On 5/22/19 1:31 PM, Zhengyu Gu wrote:
>> The idea looks good.
>>
>> Let's put the comment like:
>>
>>   672   // Deactivate barriers temporarily: Verifier wants plain heap accesses
>>   673   ShenandoahGCStateResetter resetter;
>>
>> You can common the use of ShenandoahHeap::heap() here (in fact you can probably just pull it into
>> the ShenandoahGCStateResetter const field):
>>
>>   618   ~ShenandoahGCStateResetter() {
>>   619     ShenandoahHeap::heap()->_gc_state.set(_gc_state);
>>   620     assert(ShenandoahHeap::heap()->gc_state() == _gc_state, "Should be restored");
>>   621   }
> 
> Updated: http://cr.openjdk.java.net/~zgu/JDK-8224525/webrev.01/
> 
> Okay now?

Yup, thumbs up.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190522/a9d4f4ae/signature.asc>