RFR 8224875: Shenandoah: ParallelCleaning code unloading should take lock to protect shared code roots array

Aleksey Shipilev shade at redhat.com
Wed May 29 11:31:49 UTC 2019


On 5/29/19 1:29 PM, Zhengyu Gu wrote:
>> *) Since you moved the assert in ShenandoahCodeRoots::remove_nmethod, is it worth it to move it in
>> ShenandoahCodeRoots::add_nmethod too?
>>
> Sure.

So... should we make (add|remove)_nmethod symmetrical? If remove_* can acquire the lock, then add_*
should do that too?

> Updated webrev: http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.01/

Otherwise good.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190529/ba968f9d/signature.asc>


More information about the hotspot-gc-dev mailing list