RFR(S) 8224932: Shenandoah: Rename ShenandoahHeapLock, make it general purpose lock

Aleksey Shipilev shade at redhat.com
Wed May 29 13:07:43 UTC 2019


On 5/29/19 1:43 PM, Zhengyu Gu wrote:
> On 5/29/19 7:26 AM, Aleksey Shipilev wrote:
>> On 5/29/19 1:13 PM, Zhengyu Gu wrote:
>>> Please review this refactor ShenandoahHeapLock to general purpose spin lock (I kept
>>> ShenandoahSpinLock, cause ShenandoahLock was taken in another changeset. Any other suggestions for
>>> the name?)
>>
>> I don't understand. What does it mean "cause ShenandoahLock was taken in another changeset"? There
>> are no conflicts in current jdk/jdk I can see.
> 
> Right, it is in concurrent class unloading changeset, and not yet here.

Well, that means *that* changeset should use another identifier. It has no business hoarding the
generic "ShenandoahLock", IMO.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190529/1a7f4573/signature.asc>


More information about the hotspot-gc-dev mailing list