RFR(XS) 8224247: AllocateOldGenAt fires assertion failure

[sangheon.kim at oracle.com]

Hi Kishor,

On 5/28/19 8:40 AM, Kharbas, Kishor wrote:
>
> Hi,
>
> Requesting review for,
>
> CR : https://bugs.openjdk.java.net/browse/JDK-8224247 
> <https://bugs.openjdk.java.net/browse/JDK-8224247>
>
> Webrev : http://cr.openjdk.java.net/~kkharbas/8224247/webrev.00 
> <http://cr.openjdk.java.net/%7Ekkharbas/8224247/webrev.00>
>
Looks good.
The patch passed hs-tier 1, 2 and 3.

It would be helpful if you mention what kind of tests were passed when 
send RFR.

Thanks,
Sangheon


> Changeset 54678 for https://bugs.openjdk.java.net/browse/JDK-8198505 
> <https://bugs.openjdk.java.net/browse/JDK-8198505> replaced the two 
> methods in CollectorPolicy - max_heap_byte_size() and 
> heap_reserved_size_bytes(), with a single method 
> heap_reserved_size_bytes() in [g1/parallel]Arguments.
>
> The second method was introduced in 
> https://bugs.openjdk.java.net/browse/JDK-8202286 
> <https://bugs.openjdk.java.net/browse/JDK-8202286> to differentiate 
> between the size of reserved memory (heap_reserved_size_bytes(), which 
> might be 2x of MaxHeapSize) and the max size heap can grow 
> (heap_reserved_size_bytes(), which is always MaxHeapSize). When 
> 'AllocateOldGenAt' flag is used, during heap initialization we need 
> the first size and later on the second size. Adding the second method 
> back fixes the issue.
>
> The fix is just adding a new method and using it during initialization 
> of G1 and PS heap, but the existing method's name is more appropriate 
> for the new method. So I renamed existing method. This would also 
> avoid confusion about these methods down the line.
>
> Please suggest alternated approach if you see one.
>
> Thanks,
>
> Kishor
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190529/ef50bbe1/attachment.htm>