RFR (S): 8223162: Increase ergonomics for Sparse PRT entry sizing

[sangheon.kim at oracle.com]

Hi Thomas,

On 5/27/19 1:44 AM, Thomas Schatzl wrote:
> Hi Kim,
>
> On Fri, 2019-05-24 at 17:26 -0400, Kim Barrett wrote:
>>> On May 24, 2019, at 9:24 AM, Thomas Schatzl <
>>> thomas.schatzl at oracle.com> wrote:
>>> […]CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8223162
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8223162/webrev/
>>> Testing:
>>> lots of remembered set size measurements on lots of applications,
>>> some
>>> hs-tier1-5 runs together with other changes.
>>>
>>> Thanks,
>>>   Thomas
>> src/hotspot/share/gc/g1/sparsePRT.hpp
>>   241   enum SomeAdditionalPrivateConstants {
>>   242     InitialCapacity = 8
>>   243   };
>>
>> Since you are touching it, consider making InitialCapacity a static
>> const size_t rather than an enumerator, so it has a consistent type
>> across platforms.
>>
>> Other than that, looks good.  I don't need a new review if you change
>> how InitialCapacity is defined.
>>
>    thanks for your review. I changed InitialCapacity to a static const
> as suggested and regenerated the webrev.
Looks good to me too.

Thanks,
Sangheon


>
> Thanks,
>    Thomas
>
>