RFR(M): 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3)

sangheon.kim at oracle.com sangheon.kim at oracle.com
Tue Oct 22 16:47:56 UTC 2019


Hi Kim,

On 10/22/19 12:19 AM, Kim Barrett wrote:
>> On Oct 22, 2019, at 1:52 AM, sangheon.kim at oracle.com wrote:
>> What do you think about below comment?
>>
>>    // Tries to allocate word_sz in the PLAB of the next "generation" after trying to
>>    // allocate into dest. Previous_plab_refill_failed indicates whether previous
>>    // PLAB refill for the original (source) object was failed.
> Drop “was”.  Otherwise looks good.
Done.

Webrev:
http://cr.openjdk.java.net/~sangheki/8220311/webrev.3
http://cr.openjdk.java.net/~sangheki/8220311/webrev.3.inc

Thanks,
Sangheon


>
>>    // Returns a non-NULL pointer if successful, and updates dest if required.
>>    // Also determines whether we should continue to try to allocate into the various
>>    // generations or just end trying to allocate.
>>    HeapWord* allocate_in_next_plab(G1HeapRegionAttr* dest,
>> ...
>>
>> Let me post the webrev when we decide. :)
>>
>> Thanks,
>> Sangheon
>>
>>
>>> ------------------------------------------------------------------------------
>>>
>>> Looks good, other than that one comment issue.
>




More information about the hotspot-gc-dev mailing list