RFR(T): 8230642: 8224815 broke Shenandoah build

[Doerr, Martin]

Hi Thomas,

feel free to push Aleksey's version. Looks good and fixes the build.

Thanks and best regards,
Martin


> -----Original Message-----
> From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> On
> Behalf Of Aleksey Shipilev
> Sent: Donnerstag, 5. September 2019 10:57
> To: Thomas Stüfe <thomas.stuefe at gmail.com>; Hotspot-Gc-Dev <hotspot-
> gc-dev at openjdk.java.net>
> Subject: Re: RFR(T): 8230642: 8224815 broke Shenandoah build
> 
> On 9/5/19 10:19 AM, Thomas Stüfe wrote:
> > https://bugs.openjdk.java.net/browse/JDK-8230642
> > http://cr.openjdk.java.net/~stuefe/webrevs/8224815-broke-shenandoah-
> build/8224815-broke-shenandoah-build.patch
> 
> Thanks for fixing this.
> 
> The change looks good, but to match the style, I would go with:
> 
> diff -r 66bb1335f8c5
> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp        Mon Sep
> 02 21:12:56 2019 +0200
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp        Thu Sep
> 05 10:29:17 2019 +0200
> @@ -212,10 +212,12 @@
>    size_t    _num_regions;
>    ShenandoahHeapRegion** _regions;
>    ShenandoahRegionIterator _update_refs_iterator;
> 
>  public:
> +  inline HeapWord* base() const { return _heap_region.start(); }
> +
>    inline size_t num_regions() const { return _num_regions; }
>    inline bool is_heap_region_special() { return _heap_region_special; }
> 
> This passes hotspot_gc_shenandoah.
> 
> --
> Thanks,
> -Aleksey