RFR: 8231113: Adjust CollectedHeap::check_oop_location()

Per Liden per.liden at oracle.com
Thu Sep 19 13:51:46 UTC 2019


Thanks for reviewing!

/Per

On 9/19/19 2:53 PM, Thomas Schatzl wrote:
> Hi Per,
> 
> On Thu, 2019-09-19 at 13:23 +0200, Per Liden wrote:
>> Hi Stefan,
>>
>> On 2019-09-17 21:48, Stefan Karlsson wrote:
>>> Hi Per,
>>>
>>> I think both names are bad because the functions return false
>>> positives but the names give the impression that they won't. For
>>> example:
>>>
> [...]
>> I actually think I'd prefer removing check_oop_location() all
>> together, with the rational that some of the asserts where it's used
>> today are "conceptually wrong". In the other cases (e.g. in
>> CompressedOops and G1), we can make valid checks using better
>> mechanisms.
>>
>> So, how about this:
>>
>> http://cr.openjdk.java.net/~pliden/8231113/webrev.1
> 
> Looks good.
> 
> Thomas
> 
> 



More information about the hotspot-gc-dev mailing list