[15] RFR(T) 8243848: Shenandoah: Windows build fails after JDK-8239786

Zhengyu Gu zgu at redhat.com
Tue Apr 28 14:02:36 UTC 2020


Yea, need some coffee ...

Updated: http://cr.openjdk.java.net/~zgu/JDK-8243848/webrev.01/index.html

-Zhengyu

On 4/28/20 8:46 AM, Roman Kennke wrote:
> If ConcGCThread and ParallelGCThread are uint, then making _max_workers
> uint too seems only consequential. Or what am I missing?
> 
> Roman
> 
> 
>>
>> On 4/28/20 8:26 AM, Roman Kennke wrote:
>>> Would it be more useful to make _max_workers uint to begin with?
>>
>> That will have much wider implication, especially, it is derived from
>> ConcGCThreads and ParallelGCThreads, which are uints. So, you will see
>> conversions in other places.
>>
>>
>> -Zhengyu
>>
>>>
>>> Roman
>>>
>>>
>>>> Please review this small patch that fixes build problems (size_t => uint
>>>> type conversion) on Windows.
>>>>
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8243848
>>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8243848/webrev.00/
>>>>
>>>> Test:
>>>>     Built on Windows.
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>
>>>
>>
> 




More information about the hotspot-gc-dev mailing list