RFR: 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow [v5]
Jie Fu
jiefu at openjdk.java.net
Wed Dec 2 04:12:16 UTC 2020
> Hi all,
>
> SIGFPE was observed by running:
> java -XX:G1ConcRefinementThresholdStep=16G -XX:G1UpdateBufferSize=1G -version
>
> The reason is that buffers_to_cards [1] returns 0 for 'step' due to overflow.
> It would be better to add overflow check logic is it.
>
> Testing:
> - tier1 on Linux/x64
>
> Thanks.
> Best regards,
> Jie
>
> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp#L235
Jie Fu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Eliminate the casts
- Merge branch 'master' into JDK-8257228
- Only run the test on 64-bit machines
- Fix build error without PCH
- Merge branch 'master' into JDK-8257228
- Refine the erro msg
- Fix mul-overflow-check and error reporting
- 8257228: G1: SIGFPE in G1ConcurrentRefine::create(int*) due to buffers_to_cards overflow
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1489/files
- new: https://git.openjdk.java.net/jdk/pull/1489/files/8bdeb20a..efa0946c
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1489&range=04
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1489&range=03-04
Stats: 11737 lines in 303 files changed: 9388 ins; 869 del; 1480 mod
Patch: https://git.openjdk.java.net/jdk/pull/1489.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1489/head:pull/1489
PR: https://git.openjdk.java.net/jdk/pull/1489
More information about the hotspot-gc-dev
mailing list