RFR: 8257820: Remove gc/ergonomics/TestMinHeapSize.java as it is too brittle

Kim Barrett kbarrett at openjdk.java.net
Mon Dec 7 12:43:14 UTC 2020


On Mon, 7 Dec 2020 12:29:21 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that removes the gc/ergonomics/TestMinHeapSize.java test?
> 
> We found that it is unstable, and with reasonable effort very likely can't be made to work: we have no idea how much (C heap) memory the rest of the VM will use, or will in the future, so there will likely always be a constant need to update it. Even during review there have already some adaptations to make it work, until it "worked", but then it intermittently started failing in CI anyway.
> 
> Testing: this is a trivial removal of a complete test/file.
> 
> Thanks,
>   Thomas

Looks good, and trivial.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1664



More information about the hotspot-gc-dev mailing list