RFR: JDK-8256155: os::Linux Populate all large_page_sizes, select smallest page size in reserve_memory_special_huge_tlbfs* [v9]

Tue Dec 8 18:48:10 UTC 2020

On Tue, 8 Dec 2020 18:00:35 GMT, Marcus G K Williams <github.com+168222+mgkwill at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 3726:
>> 
>>> 3724: }
>>> 3725: 
>>> 3726: void os::Linux::register_large_page_sizes() {
>> 
>> Please refactor to remove duplicated code with` find_large_page_size`, probably use `register_large_page_sizes` to eliminate the need for `find_large_page_size`
>
> In latest patch I removed Linux::find_large_page_size and use register_large_page_sizes. I tried to streamline Linux::setup_large_page_size.

with those changes, you have created a bug on os::large_page_size(), I don't think _large_page_size is set (unless I missed it).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153