RFR: 8258142: Simplify G1RedirtyCardsQueue

Ivan Walulya iwalulya at openjdk.java.net
Mon Dec 14 12:48:55 UTC 2020


On Sun, 13 Dec 2020 01:45:20 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this change to G1RedirtyCardsQueue to separate the local qset
> from the queue. This simplifies the implementation, though requires clients
> to deal with the local qset explicitly. This is an enabling step toward
> desired simplifications of the PtrQueue hierarchy. This change also
> simplifies the interaction between the local qset and the global qset.
> 
> Testing:
> mach5 tier1-5

looks good

minor:
maybe maintain the postfix `_qset ` in the naming of `_rdclqs` as done for `_shared_qset` and `_local_qset`

-------------

Marked as reviewed by iwalulya (Committer).

PR: https://git.openjdk.java.net/jdk/pull/1755



More information about the hotspot-gc-dev mailing list