[14] RFR (S): 8237079: gc/g1/mixedgc/TestLogging.java fails with "Pause Young (Mixed) (G1 Evacuation Pause) not found"

Kim Barrett kim.barrett at oracle.com
Wed Jan 22 22:21:32 UTC 2020


> On Jan 22, 2020, at 5:46 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi all,
> 
> On 17.01.20 16:07, Leo Korinth wrote:
>> Hi Thomas,
>> This is not a review. This code is basically the same code as is 
> 
> I took it as one anyway ;)
> 
>> duplicated at least three times in the test code. One of the duplications you can blame me for, *sorry*. I believe it should be moved to a common library method. I also believe the last fix you did in TestG1ParallelPhases.java makes that version look cleaner than what you propose here (it does not need the last allocation loop at all).
>> How about using the TestG1ParallelPhases.java version for all three test cases? If not, do the third version in TestOldGenCollectionUsage really work???
> 
> Here's a webrev incorporating these suggestions to unify the code:
> 
> http://cr.openjdk.java.net/~tschatzl/8237079/webrev.1 (full)

Looks good.



More information about the hotspot-gc-dev mailing list