[15] RFR 8245240: Shenandoah: support nesting evacuation OOM scope

Aleksey Shipilev shade at redhat.com
Wed May 20 18:44:16 UTC 2020


On 5/20/20 8:42 PM, Zhengyu Gu wrote:
> diff -r 25dc6d2ed231 
> src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp 
> Wed May 20 13:28:17 2020 -0400
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahThreadLocalData.hpp 
> Wed May 20 14:34:41 2020 -0400
> @@ -159,6 +159,8 @@
>     // Push the scope one level deeper, return previous level
>     static uint8_t push_evac_oom_scope(Thread* thread) {
>       uint8_t level = evac_oom_scope_level(thread);
> +    // UINT_MAX = 255
> +    assert(level < 254, "Overflow nesting level");
>       data(thread)->_oom_scope_nesting_level = level + 1;
>       return level;
>     }

OK, fine. You can put the comment at the same line.

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list