RFR: 8256051: nmethod_entry_barrier stub miscalculates xmm spill size on x86_32

Aleksey Shipilev shade at openjdk.java.net
Wed Nov 11 17:41:57 UTC 2020


On Wed, 11 Nov 2020 16:46:43 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> nmethod_entry_barrier stub miscalculates xmm spill size on x86_32, instead of 4 * wordSize, it uses 2 * wordSize.
> 
> This bug only affects Shenandoah, as it is the only GC that supports concurrent class unloading on x86_32.

D'oh. Seems like a simple error while copy-pasting from `stubGenerator_x86_64.cpp`. Looks fine and trivial to me. I ran `x86_32` + `tier1` + `Shenandoah` tests on my own with this change, and it improves the test results a lot.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1170



More information about the hotspot-gc-dev mailing list