Integrated: 8256426: Shenandoah: Remove superfluous assert is ShBS::load_reference_barrier()

Roman Kennke rkennke at openjdk.java.net
Tue Nov 17 17:13:06 UTC 2020


On Tue, 17 Nov 2020 15:25:37 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Some of heap walk related tests in nsk/jdi suite failed after concurrent weak reference processing.
> 
> Can be easily reproduced:
> TEST_VM_OPTS="-XX:+UseShenandoahGC" make CONF=linux-x86_64-server-fastdebug run-test TEST=vmTestbase/nsk/jdi/ObjectReference/referringObjects/referringObjects001/referringObjects001.java 
> 
> It asserts that no non-Java thread accesses references with weak/unknown strength. However, JVMTI will do just that when heap-walking and I can't see how that would be problematic, as long as we don't resurrect objects, and we don't.
> 
> Testing:
>  - [x] the failing test 
>  - [x] vmTestbase_nsk_jdi +UseShenandoahGC
>  - [x] hotspot_gc_shenandoah
>  - [x] tier1 +UseShenandoahGC
>  - [x] tier2 +UseShenandoahGC

This pull request has now been integrated.

Changeset: 9efbb463
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/9efbb463
Stats:     1 line in 1 file changed: 0 ins; 1 del; 0 mod

8256426: Shenandoah: Remove superfluous assert is ShBS::load_reference_barrier()

Reviewed-by: shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/1261



More information about the hotspot-gc-dev mailing list