RFR: 8255019: Shenandoah: Split STW and concurrent mark into separate classes [v14]

Zhengyu Gu zgu at openjdk.java.net
Mon Nov 23 19:54:59 UTC 2020


On Fri, 20 Nov 2020 20:20:14 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>> 
>>  - Merge
>>  - Moved task queues to marking context
>>  - Merge
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Removed obsoleted class
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - ... and 10 more: https://git.openjdk.java.net/jdk/compare/98a5d5a6...8c58f6f4
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 373:
> 
>> 371:   // call the entry method below
>> 372:   void vmop_entry_init_mark(ShenandoahConcurrentMark* mark);
>> 373:   void vmop_entry_final_mark(ShenandoahConcurrentMark* mark);
> 
> I find it odd that those entries now take ShenandoahConcurrentMark instance as argument, while all others don't. In particular because it implies it is the concurrent version anyway. Why is this necessary?

ShenandoahConcurrentMark is stateless, can be created in place. The parameters are removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1009



More information about the hotspot-gc-dev mailing list