RFR: 8254999: Move G1RemSetSamplingTask to more appropriate location [v2]
Stefan Johansson
sjohanss at openjdk.java.net
Tue Nov 24 09:42:59 UTC 2020
On Tue, 24 Nov 2020 09:03:03 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Stefan Johansson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'master' into 8254999-move-sampling-task
>> - 8254999: Move G1RemSetSampligTask to more appropriate location
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 599:
>
>> 597: // Do the actual sampling.
>> 598: sample_young_list_rs_length(&sts);
>> 599: schedule(G1ConcRefinementServiceIntervalMillis);
>
> I am good with the new location of the code but I would prefer if this change would be limited to the move and not change the rescheduling logic.
> If it's not too much of a bother please split this out into a second CR.
Thanks for looking at this Thomas. I removed the scheduling logic and filed: [JDK-8252645](https://bugs.openjdk.java.net/browse/JDK-8252645)
-------------
PR: https://git.openjdk.java.net/jdk/pull/1395
More information about the hotspot-gc-dev
mailing list