Integrated: 8252645: Change time measurements in G1ServiceThread to only account remembered set work

[Stefan Johansson]

On Thu, 26 Nov 2020 10:35:35 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

> Please review this change to move the timing of how much time is spent doing remembered set sampling into the task doing the sampling. The timing has historically been part of the service thread, because in the past the only thing the thread did was sampling. Now when both uncommit work and periodic GC scheduling has been added, the timing needs to be moved into the sampling task.
> 
> I've also slightly changed the output using this information to:
> [0,295s][trace][gc,remset   ] GC(0)   Sampling task time (ms)
> [0,295s][trace][gc,remset   ] GC(0)           0,000
> Instead of the old:
> [0,301s][trace][gc,remset   ] GC(0)   Service thread time (s)
> [0,301s][trace][gc,remset   ] GC(0)           0,00
> 
> I decided to change the unit to ms because the time spent doing sampling is very small and is better measured in milliseconds. When doing so I also went with three decimals since this is what we normally do for milliseconds.

This pull request has now been integrated.

Changeset: ee99686b
Author:    Stefan Johansson <sjohanss at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ee99686b
Stats:     100 lines in 6 files changed: 53 ins; 34 del; 13 mod

8252645: Change time measurements in G1ServiceThread to only account remembered set work

Reviewed-by: ayang, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/1447