RFR: 8257145: Performance regression with -XX:-ResizePLAB after JDK-8079555

Thomas Schatzl tschatzl at openjdk.java.net
Fri Nov 27 09:42:01 UTC 2020


On Fri, 27 Nov 2020 03:37:42 GMT, Dongbo He <dongbohe at openjdk.org> wrote:

> Hi,
> 
> this is the continuation of the review of the implementation for:
> 
> https://bugs.openjdk.java.net/browse/JDK-8257145

Changes requested by tschatzl (Reviewer).

src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 1409:

> 1407:   _bytes_used_during_gc(0),
> 1408:   _archive_allocator(NULL),
> 1409:   _survivor_evac_stats("Young", YoungPLABSize * ParallelGCThreads, PLABWeight),

Lgtm, will do some perf measurements and get back to you.
Could you add a comment like the following in the G1EvacStats constructor?

// desired_plab_size_ should be the total PLAB size for all threads.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1474



More information about the hotspot-gc-dev mailing list