RFR: 8214455: Relocate CDS archived regions to the top of the G1 heap [v2]
Ioi Lam
iklam at openjdk.java.net
Tue Apr 6 17:04:19 UTC 2021
On Tue, 6 Apr 2021 09:35:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @tschatzl review -- fix typos and whitespace
>
> src/hotspot/share/memory/filemap.cpp line 1846:
>
>> 1844: _heap_pointers_need_patching = true;
>> 1845: } else if (header()->heap_end() != CompressedOops::end()) {
>> 1846: log_info(cds)("CDS heap data need to be relocated to the end of the runtime heap to reduce fragmentation");
>
> s/need/needs
Fixed.
> test/hotspot/jtreg/runtime/cds/appcds/cacheObject/HeapFragmentationTest.java line 30:
>
>> 28: * @bug 8214455
>> 29: * @requires vm.cds.archived.java.heap
>> 30: * @requires (sun.arch.data.model == "64" & os.maxMemory > 4g)
>
> additional space before the &
Fixed. Thanks for the review.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3349
More information about the hotspot-gc-dev
mailing list