RFR: 8264423: G1: Rename full gc attribute table states [v3]
Hamlin Li
mli at openjdk.java.net
Wed Apr 14 12:35:02 UTC 2021
On Wed, 14 Apr 2021 12:11:13 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this cleanup change suggested in PR#2760 that renames some code in the g1 full gc attribute table.
>>
>> This is the description from the CR:
>>
>>> Since JDK-8253600 g1 full gc has its own (temporary) attribute table storing information that it needs for evacuation.
>>>
>>> Currently the naming corresponds to the attributes in HeapRegion. This is somewhat confusing, as they do not completely match.
>>>
>>> While discussing this in the review for JDK-8262068 we thought of changing this to more reflect the purpose:
>>>
>>> I.e.
>>> closed -> not_marked_through (or "always live" or "always_marked" something similar to indicate that we do not need to mark through them)
>>> pinned -> not_compacted
>>> normal -> compacted (or just keep "normal" as it is some internal state)
>>
>> Some additional renaming has been performed.
>>
>> Testing: tier1-5
>
> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
>
> - Skip marking
> - Try always live
looks good.
-------------
Marked as reviewed by mli (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3486
More information about the hotspot-gc-dev
mailing list