RFR: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Fri Apr 16 14:00:54 UTC 2021


On Fri, 16 Apr 2021 10:01:33 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this change that skips the rebuild remset phase and the associated updates after rebuild, If during Remark, G1 finds that there are no remembered sets to rebuild.
>> 
>> Test: tier1-5
>
> Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Fix issues raised in Thomas review, and add test
>  - Merge remote-tracking branch 'upstream/master' into JDK-8199407
>  - remove trailing white space
>  - Merge branch 'master' into JDK-8199407
>  - variable name refactor
>  - variable name refactor
>  - skip iterations that depend on total_selected_for_rebuild
>  - skip the rebuild remembered set phase if remark did not select any regions for rebuilding

Lgtm after looking at some logs and playing with some log options. Sorry for the confusion.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3434



More information about the hotspot-gc-dev mailing list