RFR: 8265461: G1: Forwarding pointer removal thread sizing [v2]

[Thomas Schatzl]

On Tue, 20 Apr 2021 13:59:09 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Added comment
>>  - iwalulya lkorinth reviews
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 3665:
> 
>> 3663: 
>> 3664:   _expand_heap_after_alloc_failure = true;
>> 3665:   _num_regions_failed_evacuation = false;
> 
> _num_regions_failed_evacuation = 0; ?

Fixed.

> src/hotspot/share/gc/g1/g1EvacFailure.cpp line 211:
> 
>> 209: 
>> 210: public:
>> 211:   RemoveSelfForwardPtrHRClosure(G1RedirtyCardsQueueSet* rdcqs, uint worker_id, uint volatile* num_failed_regions) :
> 
> Maybe increment failed regions through G1CollectedHeap instead of a pointer to the value?

You probably mean `G1ParRemoveSelfForwardPtrsTask`. I would not want to add that counter to `G1CollectedHeap` if possible. The suggestion seems to make the code just more verbose, not "cleaner", but that is subjective of course.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3585