RFR: 8276299: G1: Unify the wording buffer/node/element in G1SegmentedArrayXxx, G1CardSetXxx and related classes [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Wed Dec 1 14:57:28 UTC 2021


On Wed, 1 Dec 2021 11:56:43 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1SegmentedArray.hpp line 95:
>> 
>>> 93: // Counts and memory usage are current on a best-effort basis if accessed concurrently.
>>> 94: template<MEMFLAGS flag>
>>> 95: class G1SegmentedArrayFreeList {
>> 
>> The name should be `G1SegmentedArraySegmentList`, right?
>
> Thanks Albert.
> In fact I intended to change it "G1SegmentedArrayFreeList", I think this is more readable, and G1SegmentedArraySegmentList is a bit redundant.
> Please kindly let me know if you think otherwise.

There's a class named `G1SegmentedArraySegment`, so having `G1SegmentedArraySegmentList` as a list of `G1SegmentedArraySegment` makes perfect sense and is more consistent, IMO. Ofc, this is quite subjective; either is fine to me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6605



More information about the hotspot-gc-dev mailing list