RFR: 8278207: G1: Tighten verification in G1ResetSkipCompactingClosure

Stefan Johansson sjohanss at openjdk.java.net
Mon Dec 6 14:46:14 UTC 2021


On Fri, 3 Dec 2021 10:35:18 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of expanding the verification logic to mirror its source.
> 
> Test: tier1-5

src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp line 64:

> 62:              "should be quite full");
> 63:     }
> 64: #endif

What do you think about extracting this to a function. Something like:

void assert_should_reset(HeapRegion*) PRODUCT_RETURN;

But you might be able to come up with a better name :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6698



More information about the hotspot-gc-dev mailing list