RFR: 8278207: G1: Tighten verification in G1ResetSkipCompactingClosure
Albert Mingkun Yang
ayang at openjdk.java.net
Tue Dec 7 13:40:11 UTC 2021
On Tue, 7 Dec 2021 09:09:02 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
> If we want more documentation I would rather see a comment explaining in what situations regions might be marked as "skip compacting".
These asserts serve as "runnable" documentation -- less likely to deviate from the actual code.
> One other question, can we ever end up here with a closed archive region? Those are marked SkipMarking so I guess they should be filtered out above?
Yes; you are right. I should put `ShouldNotReachHere()` for closed-archive regions.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6698
More information about the hotspot-gc-dev
mailing list