[jdk18] RFR: 8278389: SuspendibleThreadSet::_suspend_all should be volatile/atomic [v3]

Thomas Schatzl tschatzl at openjdk.java.net
Mon Dec 13 11:10:53 UTC 2021


> Hi all,
> 
> can I have reviews for this change that makes SuspendibleThreadSet::_suspend_all volatile and all accesses to it use Atomic helpers?
> 
> I found that the only getter for that member is called SuspendibleThreadSet::should_yield(), which contradicts our naming rules; to keep the change minimal (and the naming discussion out of this PR because I do not feel that _suspend_all is particularly good) I introduced a private suspend_all() method.
> I can of course add some renaming in this change (but then for jdk19+ only).
> 
> Testing: gha, local compilation
> 
> Thanks,
> Thomas

Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:

 - Revert of dummy change
 - Another dummy change

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk18/pull/10/files
  - new: https://git.openjdk.java.net/jdk18/pull/10/files/2d59dde5..116bd871

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk18&pr=10&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk18&pr=10&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk18/pull/10.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/10/head:pull/10

PR: https://git.openjdk.java.net/jdk18/pull/10



More information about the hotspot-gc-dev mailing list