Integrated: 8260309: Shenandoah: Clean up ShenandoahBarrierSet

[Roman Kennke]

On Fri, 22 Jan 2021 19:03:14 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> We collected some cruft in ShenandoahBarrierSet. Time to clean it up. 
> 
> This fixes/removes a number of includes, fixes some comments and it also removes is_a() and is_aligned() which look like leftovers/requirements from earlier incarnations of the superclass BarrierSet. Using the override keyword would be useful for such situations (btw, are we ok to start using override, nullptr, auto etc in Shenandoah, or do we want to keep it C++ for backporting ease?)
> 
> One thing I was not sure about is the ShenandoahHeap* _heap field. Making it const will likely help the compiler avoid repeated access (e.g. in a number of perf-critical paths like the LRB impl). However, maybe we should get rid of the field altogether and make it explicitely using ShenandoahHeap::heap() and avoid repeated access instead of helping the compiler and hoping for the best?
> 
> Testing:
>  - [x] hotspot_gc_shenandoah release, fastdebug

This pull request has now been integrated.

Changeset: df33595e
Author:    Roman Kennke <rkennke at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/df33595e
Stats:     31 lines in 6 files changed: 4 ins; 19 del; 8 mod

8260309: Shenandoah: Clean up ShenandoahBarrierSet

Reviewed-by: shade, zgu

-------------

PR: https://git.openjdk.java.net/jdk/pull/2202