RFR: 8261356: Clean up enum G1Mark [v2]

Stefan Johansson sjohanss at openjdk.java.net
Tue Feb 9 12:58:32 UTC 2021


On Tue, 9 Feb 2021 12:45:51 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> After removing the effectively dead entry in `G1Mark`, the whole enum could be turned into a bool. The call-chain is updated and existing comments are revised.
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review

src/hotspot/share/gc/g1/g1RootClosures.cpp line 56:

> 54: class G1ConcurrentStartMarkClosures : public G1EvacuationRootClosures {
> 55:   G1SharedClosures<true>        _strong;
> 56:   G1SharedClosures<should_mark_weak>   _weak;

Sorry for being picky, but now the alignment of the variables are off. I would prefer:
Suggestion:

  G1SharedClosures<true>             _strong;
  G1SharedClosures<should_mark_weak> _weak;

-------------

PR: https://git.openjdk.java.net/jdk/pull/2461



More information about the hotspot-gc-dev mailing list