RFR: 8270869: G1ServiceThread may not terminate

Albert Mingkun Yang ayang at openjdk.java.net
Sun Jul 18 16:52:55 UTC 2021


On Sun, 18 Jul 2021 15:00:10 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this fix of a rare race in G1ServiceThread termination that
> can lead to the thread not terminating in a timely manner.
> 
> Testing:
> mach5 tier1

Only a minor comment on the style; I think not using `else-if` is clearer: the early-return handles the exiting condition, and the other two cases depend on the task queue state.

-------------

Marked as reviewed by ayang (Committer).

PR: https://git.openjdk.java.net/jdk/pull/4819



More information about the hotspot-gc-dev mailing list