RFR: 8262885: Shenandoah: FullGC prologue does not need to save/restore heap has_forwarded_object flag [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed Mar 3 13:33:10 UTC 2021


On Wed, 3 Mar 2021 13:30:29 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Another trivial cleanup. FullGC prologue code does not change heap's has_forwarded_objects flag, there is no point to save/restore it.
>> 
>> Test:
>> - [x] hotspot_gc_shenandoah
>
> Zhengyu Gu has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Aleksey's comment
>  - Removed whitespaces
>  - Aleksey's comment

Good!

src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 189:

> 187:     _preserved_marks->init(heap->workers()->active_workers());
> 188:     
> 189:     assert(heap->has_forwarded_objects() == has_forwarded_objects, "Not expect to change");

"This should not change"?

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2797



More information about the hotspot-gc-dev mailing list