RFR: 8263041: Shenandoah: Cleanup C1 keep alive barrier check [v3]

Aleksey Shipilev shade at openjdk.java.net
Mon Mar 8 16:03:07 UTC 2021


On Mon, 8 Mar 2021 15:32:25 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Please review this cleanup. It appears that JDK-8233339 missed C1 change.
>> 
>> Test:
>> - [x] hotspot_gc_shenandoah
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unrelated change

Looks good, minor nit.

src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp line 554:

> 552:   }
> 553: 
> 554:   // 3: apply keep-alive barrier for java.lang.ref.Reference if needed

"For java.lang.ref.Reference"?

I think BarrierSetC2 comment if pretty generic, so we might want to match it.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2834



More information about the hotspot-gc-dev mailing list