RFR: JDK-8256155: os::Linux Populate all large_page_sizes, select smallest page size in reserve_memory_special_huge_tlbfs* [v23]

[Marcus G K Williams]

On Tue, 16 Mar 2021 09:27:45 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Marcus G K Williams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use SIZE_FORMAT in logging
>>   
>>   Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>
> src/hotspot/os/linux/os_linux.cpp line 3760:
> 
>> 3758: void os::large_page_init() {
>> 3759:   size_t default_large_page_size = scan_default_large_page_size();
>> 3760:   os::Linux::_default_large_page_size = default_large_page_size;
> 
> I would move this below the checking if large pages are enabled. I'm also not sure if this refactoring made the setup easier to follow. I would have preferred the old way, but if you and Thomas prefer this I'm ok with it.

I don't have strong feelings either way but I think the new refactoring is slightly clearer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1153