RFR: 8263832: Shenandoah: Fixing parallel thread iteration in final mark task

Roman Kennke rkennke at openjdk.java.net
Thu Mar 18 20:47:39 UTC 2021


On Thu, 18 Mar 2021 20:42:15 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> It's not trivial. Maybe I'm missing something, but where are the threads claimed now? I believe you should leave the claiming code where it is, right? And only change threads_do() to possibly_parallel_threads_do().
>
>> It's not trivial. Maybe I'm missing something, but where are the threads claimed now? I believe you should leave the claiming code where it is, right? And only change threads_do() to possibly_parallel_threads_do().
> 
> Threads are claimed inside Threads::possibly_parallel_threads_do() (https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/thread.cpp#L2866)

Ah

> > It's not trivial. Maybe I'm missing something, but where are the threads claimed now? I believe you should leave the claiming code where it is, right? And only change threads_do() to possibly_parallel_threads_do().
> 
> Threads are claimed inside Threads::possibly_parallel_threads_do() (https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/thread.cpp#L2866)

Ah ok, alright. It's clearly too late for work! Sorry for the noise.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3080



More information about the hotspot-gc-dev mailing list