RFR: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check()

Ivan Walulya iwalulya at openjdk.java.net
Tue Mar 23 09:45:49 UTC 2021


On Wed, 17 Mar 2021 13:53:36 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

> Please review this change that removes some additional verification not really needed when doing the sanity check for hugetlbfs-pages.
> 
> **Summary**
> The call to `mmap` in `hugetlbfs_sanity_check()` will only succeed if it can satisfy the mapping using large pages. If this was not the case, we would have to double check all large page mappings not just this sanity check. So the reading of `/proc/self/maps` is safe to remove.
> 
> **Testing**
> Sanity run through mach 5 and local testing with and without large pages configured.

lgtm!

src/hotspot/os/linux/os_linux.cpp line 3496:

> 3494: 
> 3495:   if (warn) {
> 3496:     warning("HugeTLBFS is not supported or configured by the operating system.");

minor: "HugeTLBFS is not configured or not supported by the operating system."

-------------

Marked as reviewed by iwalulya (Committer).

PR: https://git.openjdk.java.net/jdk/pull/3048



More information about the hotspot-gc-dev mailing list