RFR: 8231672: Simplify the reference processing parallelization framework [v4]
Leo Korinth
lkorinth at openjdk.java.net
Tue Mar 23 14:41:43 UTC 2021
On Tue, 23 Mar 2021 13:57:50 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> src/hotspot/share/gc/parallel/psScavenge.cpp line 191:
>>
>>> 189:
>>> 190: virtual void do_void() {
>>> 191: assert(_promotion_manager != nullptr, "Sanity");
>>
>> I'd prefer this assert was in the constructor.
>
> I agree. I further prefer not having an assert and instead using a reference. I also fear doing unrelated changes will be rejected. This is no new code of mine, it is added so that nullptr is used consistently after push-back from Thomas.
What would you prefer?
1) keep as is now.
2) move to constructor.
3) use a reference instead.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2782
More information about the hotspot-gc-dev
mailing list