RFR: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check() [v2]

Thomas Schatzl tschatzl at openjdk.java.net
Wed Mar 24 16:01:49 UTC 2021


On Tue, 23 Mar 2021 10:35:59 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Please review this change that removes some additional verification not really needed when doing the sanity check for hugetlbfs-pages.
>> 
>> **Summary**
>> The call to `mmap` in `hugetlbfs_sanity_check()` will only succeed if it can satisfy the mapping using large pages. If this was not the case, we would have to double check all large page mappings not just this sanity check. So the reading of `/proc/self/maps` is safe to remove.
>> 
>> **Testing**
>> Sanity run through mach 5 and local testing with and without large pages configured.
>
> Stefan Johansson has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Self review
>  - Ivan review

Lgtm.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3048



More information about the hotspot-gc-dev mailing list