Integrated: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check()
Stefan Johansson
sjohanss at openjdk.java.net
Wed Mar 24 20:31:40 UTC 2021
On Wed, 17 Mar 2021 13:53:36 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
> Please review this change that removes some additional verification not really needed when doing the sanity check for hugetlbfs-pages.
>
> **Summary**
> The call to `mmap` in `hugetlbfs_sanity_check()` will only succeed if it can satisfy the mapping using large pages. If this was not the case, we would have to double check all large page mappings not just this sanity check. So the reading of `/proc/self/maps` is safe to remove.
>
> **Testing**
> Sanity run through mach 5 and local testing with and without large pages configured.
This pull request has now been integrated.
Changeset: 623f0b6b
Author: Stefan Johansson <sjohanss at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/623f0b6b
Stats: 24 lines in 1 file changed: 1 ins; 19 del; 4 mod
8262235: Remove unnecessary logic in hugetlbfs_sanity_check()
Reviewed-by: iwalulya, tschatzl
-------------
PR: https://git.openjdk.java.net/jdk/pull/3048
More information about the hotspot-gc-dev
mailing list