RFR: 8266773: Release VM is broken with GCC 9 after JDK-8214237
Jie Fu
jiefu at openjdk.java.net
Mon May 10 13:29:59 UTC 2021
On Mon, 10 May 2021 09:31:21 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> Maybe instead use something like:
>> `out->print("%*s%s", 2 * indent_level, "", "indented*s");`
>> or:
>> `out->print("%*c%s", 2 * indent_level, ' ', "indented*c");`
>>
>> And get rid of the "Indents" string array and associated functions.
>
> The string version ("%*s") of mine is better as it will correctly indent the zero indentation case.
> Maybe instead use something like:
> `out->print("%*s%s", 2 * indent_level, "", "indented*s");`
> or:
> `out->print("%*c%s", 2 * indent_level, ' ', "indented*c");`
>
> And get rid of the "Indents" string array and associated functions.
Good suggestion!
Thanks @lkorinth .
Will update it later if there is no objection.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3941
More information about the hotspot-gc-dev
mailing list