RFR: 8266773: Release VM is broken with GCC 9 after 8214237 [v2]

[Leo Korinth]

On Mon, 10 May 2021 23:44:53 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> Release VM is broken with GCC 9 due to -Werror=format-overflow=.
>> And if this assert[1] is removed, fastdebug VM can also reproduce the same bug.
>> The key to reproduce it is to compile with -O3.
>> 
>> IMO, it seems like a false positive gcc bug.
>> But we'd better fix it since gcc 9 is assumed to be supported to build OpenJDK.
>> 
>> Thanks.
>> Best regards,
>> Jie
>> 
>> 
>> [1] https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp#L47
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove all of the old usages of indent()

src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp line 45:

> 43: #include "utilities/macros.hpp"
> 44: 
> 45: static const char* indent(uint level) {

Nice!

src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp line 356:

> 354: 
> 355: void G1GCPhaseTimes::info_time(const char* name, double value) const {
> 356:   log_info(gc, phases)("%s%s: " TIME_FORMAT, "  ", name, value);

I would prefer the fixed indentation spaces in the format string instead of in an extra argument. Same for the other cases.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3941