Integrated: 8260267: ZGC: Reduce mark stack usage

Per Liden pliden at openjdk.java.net
Thu May 20 11:36:05 UTC 2021


On Tue, 13 Apr 2021 10:55:10 GMT, Per Liden <pliden at openjdk.org> wrote:

> Under some conditions, striped marking can cause excessive mark stack memory usage. For example, when the object graph has one or more N:1 relations ships, where N is a large number.
> 
> To avoid pushing mark stack entries to already marked objects, and thus reduce mark stack memory usage, this patch adds does two things:
>  * GC threads will under some conditions mark the object before pushing, else (if the condition to mark failed)
>  * GC threads will check if the object is already marked before pushing.
> 
> The conditions for marking before pushing is:
>  * We are using a single stripe, in which cases striped marking is essentially disabled anyway.
>  * We see excessive mark stack usage. In other words, the mark stack allocator indicates "high usage".
> 
> To make this easier to review, this PR contains two commits:
>  * `ZGC: Reduce mark stack usage` - This patch adds the infrastructure needed to mark before push, but only does so if we are using a single stripe.
>  * `ZGC: Mark before push if mark stack usage is high` - This patch adds the condition to mark before push if the mark stack allocator indicates "high usage". As a bonus, this patch will also uncommit memory used for mark stacks after the marking has completed.
> 
> Testing:
>  * Tier1-7
>  * SPECjbb2015, score and marking times unaffected
>  * casparcwang at tencent.com reports that this patch, in combination with PR #3455, solves the problem for Apache Zookeeper.

This pull request has now been integrated.

Changeset: aba22656
Author:    Per Liden <pliden at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/aba22656829913d5f8d619a184c929a7de8431e4
Stats:     308 lines in 20 files changed: 204 ins; 53 del; 51 mod

8260267: ZGC: Reduce mark stack usage

Co-authored-by: Wang Chao <wchao at openjdk.org>
Co-authored-by: Hui Shi <hshi at openjdk.org>
Reviewed-by: sjohanss, ayang

-------------

PR: https://git.openjdk.java.net/jdk/pull/3460



More information about the hotspot-gc-dev mailing list