RFR: 8267845: Add @requires to avoid running G1 large pages test with wrong page size

Stefan Johansson sjohanss at openjdk.java.net
Mon May 31 12:11:24 UTC 2021


On Thu, 27 May 2021 16:25:56 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Please review this small test-fix.
>> 
>> **Summary**
>> These two tests try to verify that large pages are used correctly for the heap and the G1 internal data structures. The tests start separate processes that are run with specific arguments to know the expected outcome. The sub-processes don't inherit any parameters passed to the test. This is good, but if the parameter `LargePageSizeInBytes` is passed to the test, the driver process will run with this flag and pick up a different large page size than test-processes. This won't work since the driver will use its found large page size to verify the output from the test.
>> 
>> The simple fix is to simply not run this test if this flag is specified. For the test to work with this flag, more work has to be done to analyze how different page sizes will affect the test and for now I think this is the best approach.
>> 
>> **Testing**
>> Manual verification the the tests won't run if `LargePageSizeInBytes` is set.
>
> Marked as reviewed by tschatzl (Reviewer).

Thanks for the reviews @tschatzl and @kimbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/4226



More information about the hotspot-gc-dev mailing list